xarray icon indicating copy to clipboard operation
xarray copied to clipboard

Added test for issue #6002 (currently fails)

Open RubendeBruin opened this issue 2 years ago • 6 comments

  • [ ] Closes #xxxx
  • [X] Tests added

RubendeBruin avatar Nov 18 '21 13:11 RubendeBruin

Great! If you add an xfail we can merge...

max-sixty avatar Nov 18 '21 20:11 max-sixty

Hi @max-sixty , what is a xfail ?

Also, the issue turned out to be bottleneck-bug , ref: https://github.com/pydata/bottleneck/issues/393#issuecomment-978017397 (fix available)

RubendeBruin avatar Nov 25 '21 12:11 RubendeBruin

Hi @max-sixty , what is a xfail ?

https://docs.pytest.org/en/6.2.x/skipping.html — it marks the test as "expected failure".

Also, the issue turned out to be bottleneck-bug , ref: pydata/bottleneck#393 (comment) (fix available)

Great that it's fixed upstream! We can either wait for it to be released and then merge this, or merge this now with the xfail

max-sixty avatar Nov 25 '21 14:11 max-sixty

I've added xfail , thanks for the link.

RubendeBruin avatar Nov 25 '21 15:11 RubendeBruin

@RubendeBruin it seems my guidance was bad — the test failures suggest that because this is a segfault xfail doesn't work, because the whole program crashes.

So instead, let's leave this open until bottleneck does a release, and then merge this as a passing test — does that work on your end?

max-sixty avatar Nov 25 '21 18:11 max-sixty

"does that work on your end?"

yes it does. Will remove the xfail and then we can merge once https://github.com/pydata/bottleneck/pull/382 is merged.

RubendeBruin avatar Nov 29 '21 08:11 RubendeBruin