xarray
xarray copied to clipboard
Optional tolerance feature to isin per issue #5587
- [x] Closes #5587
- [x] Tests added
- [x] Passes
pre-commit run --all-files
- [x] User visible changes (including notable bug fixes) are documented in
whats-new.rst
- ~~New functions/methods are listed in
api.rst
~~ doesn't appear to be necessary
This implementation is similar to suggested vectorized solution 1, but acts more according to the issue specifications.
I'm pretty this pull fails checks 4 and 5, but they may not be relevant to expanding functions from the apply_ufunc
dispatcher?
I will write an update if this is the case or any other changes are required.
Unit Test Results
6 files 6 suites 47m 40s :stopwatch: 16 267 tests 14 537 :heavy_check_mark: 1 730 :zzz: 0 :x: 90 798 runs 82 619 :heavy_check_mark: 8 179 :zzz: 0 :x:
Results for commit b2e32aaa.
:recycle: This comment has been updated with latest results.
Hello @shazelquist! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: