sparse icon indicating copy to clipboard operation
sparse copied to clipboard

added svg logo and logo-generating script

Open jamestwebber opened this issue 3 years ago • 13 comments

A PR to address #554. I may have gone a little bit crazy with it 😂 it was fun though

I wrote a script to generate an SVG logo with some random opacity, and modified the docs so that it looks right. That may seem crazy but the motivations were a) it was fun to do and b) there might be a lot of bike-shedding on this, and I'm not good enough with a Affinity Designer to make changes to an image quickly.

One question I had to decide: in the docs, the logo is shown on two different backgrounds. If I just used opacity then it looks very different, so I added white background squares. But this also looks a little odd on the blue background in the sidebar. The original logo didn't actually use opacity so it wasn't an issue there.

jamestwebber avatar Aug 16 '22 20:08 jamestwebber

I wrote a script to generate an SVG logo with some random opacity, and modified the docs so that it looks right. That may seem crazy but the motivations were a) it was fun to do and b) there might be a lot of bike-shedding on this, and I'm not good enough with a Affinity Designer to make changes to an image quickly.

No bike shedding from my side -- I'd just fix the seed for reproducibility but other than that, we're good.

The test failures should be resolved when #555 is in.

hameerabbasi avatar Aug 17 '22 03:08 hameerabbasi

No bike shedding from my side -- I'd just fix the seed for reproducibility but other than that, we're good.

Seed is set at 1 (0 didn't look random enough).

jamestwebber avatar Aug 17 '22 03:08 jamestwebber

Could you merge/rebase master and we should be good to go.

hameerabbasi avatar Aug 17 '22 03:08 hameerabbasi

Codecov Report

Merging #556 (6288a85) into master (6288a85) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6288a85 differs from pull request most recent head 2fd41e6. Consider uploading reports for the commit 2fd41e6 to get more accurate results

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          20       20           
  Lines        3120     3120           
=======================================
  Hits         2880     2880           
  Misses        240      240           

codecov[bot] avatar Aug 17 '22 03:08 codecov[bot]

Currently on mobile so cannot really check much, but could you ensure that it also looks nice in dark mode?

headtr1ck avatar Aug 17 '22 17:08 headtr1ck

I don't think we have a dark mode. It doesn't seem to come vanilla.

hameerabbasi avatar Aug 17 '22 17:08 hameerabbasi

Yeah when I view the docs after building locally I don't see an option for a dark mode. But I set the SVG background to black and took a screenshot::

Screen Shot 2022-08-17 at 13 47 27

jamestwebber avatar Aug 17 '22 17:08 jamestwebber

My aesthetic sense is close to none, I'll let you be the judge of how that'll blend in.

hameerabbasi avatar Aug 17 '22 18:08 hameerabbasi

Yeah, maybe removing the white parts again and instead of using semi-transparent tiles, simply tiles with a lighter color?

headtr1ck avatar Aug 17 '22 21:08 headtr1ck

Yeah, maybe removing the white parts again and instead of using semi-transparent tiles, simply tiles with a lighter color?

This does look pretty sweet on a dark background, but IMO it looks worse on the blue background of the docs page sidebar. Given that there isn't actually a dark mode for the docs, I'm inclined to keep it with the white background.

Screen Shot 2022-08-17 at 18 58 36 Screen Shot 2022-08-17 at 18 58 50

jamestwebber avatar Aug 17 '22 22:08 jamestwebber

Maybe having two versions is also ok? Alternatively, you can use CSS to change the color of the background to/from transparent to white?

headtr1ck avatar Aug 18 '22 06:08 headtr1ck

I have noticed that you removed the spacing between the sides. Maybe it was too large in the initial version but I think no spacing is confusing, at least for the cube-2D intersection.

headtr1ck avatar Aug 18 '22 11:08 headtr1ck

Okay this is why I made the script 😂 I don't really have time to make additional tweaks but happy for you to play with it more.

jamestwebber avatar Aug 20 '22 00:08 jamestwebber

Merging as-is for now... -- Thanks, @jamestwebber!-

hameerabbasi avatar Nov 20 '22 04:11 hameerabbasi