pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Published 20 hours ago • verified publisher icon pydata

mistune-3.0.0a1 breaks things

Open jarrodmillman opened this issue 2 years ago • 3 comments

With mistune-2.0.3 and nbconvert-7.0.0rc2, things work. With mistune-3.0.0a1 and nbconvert-7.0.0rc2 we get:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/nbconvert/filters/markdown_mistune.py", line 49, in MathBlockParser
    RULE_NAMES = ("multiline_math",) + BlockParser.RULE_NAMES
AttributeError: type object 'BlockParser' has no attribute 'RULE_NAMES'

This depends on one of these two upstream issues:

  • https://github.com/jupyter/nbconvert/issues/1787
  • https://github.com/jupyter/nbconvert/issues/1685

jarrodmillman avatar Jul 12 '22 21:07 jarrodmillman

Good catch - I added the two upstream issues that I think need to be resolved for this one to be fixed.

Do you think that this issue should block the next release (via being attached to this milestone)? I think that might be a while before this is fixed

choldgraf avatar Jul 13 '22 18:07 choldgraf

I'm going to bump this one to 0.11, since I think we want to make a release before this issue will likely be resolved.

choldgraf avatar Jul 15 '22 09:07 choldgraf

An update for Mistune v3 is already prepared in jupyter/nbconvert#1820, just waiting for a final release.

marmitar avatar Aug 06 '22 07:08 marmitar

we are not directly impoting mistune ourselves, is'nt something that should be handled from nbconvert ?

12rambau avatar Jun 01 '23 17:06 12rambau

https://pypi.org/project/mistune/3.0.0/ is out. Now we just need to wait for nbconvert to update:

  • https://github.com/jupyter/nbconvert/blob/main/pyproject.toml

I will close this and comment on the nbconvert issue and PR.

jarrodmillman avatar Jun 08 '23 19:06 jarrodmillman