pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

More updates into the workflows are needed after stb landed

Open damianavila opened this issue 3 years ago • 4 comments

A first iteration of the workflow updates was done in #519. But there are still some other things to update, ie:

  • Quotes in all the py versions: https://github.com/pydata/pydata-sphinx-theme/pull/519#discussion_r762245228
  • Audit section updates are needed: https://github.com/pydata/pydata-sphinx-theme/pull/519#issuecomment-985831436

This issue was created to catch those ones (and others) and eventually fix them.

damianavila avatar Dec 06 '21 14:12 damianavila

I think this is now closeable since all of the linked PRs are merged!

choldgraf avatar Jan 07 '22 00:01 choldgraf

These items are referencing comments about things missing from those merged PRs, so I have re-opened this one :wink:

damianavila avatar Jan 07 '22 21:01 damianavila

ah I see - sorry that wasn't clear to me, I just saw merged issues and assumed they were todo items that had been completed

choldgraf avatar Jan 07 '22 23:01 choldgraf

Don't worry about it!

damianavila avatar Jan 10 '22 18:01 damianavila

  • we are using quotes for all the .github actions python versions
  • the file has been cleaned from old stuff since the start of the year

closing as the comments are not relevant to the current status of the files anymore

12rambau avatar Oct 18 '22 15:10 12rambau