pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Published 20 hours ago • verified publisher icon pydata

Migrate version switcher JS from the jinja templates

Open damianavila opened this issue 3 years ago • 3 comments

On the version switcher PR that was recently merged I have requested some changes ( https://github.com/pydata/pydata-sphinx-theme/pull/436#discussion_r755515548) that we agreed it would be material for a follow-up PR. This is an issue to capture that idea and link the implementation when that one is written.

damianavila avatar Dec 03 '21 21:12 damianavila

FWIW, this interfaces closely with https://github.com/pradyunsg/sphinx-basic-ng/issues/12 (where I'm trying to figure out a way to have agnostic-to-hosting version and language switchers).

pradyunsg avatar Dec 04 '21 08:12 pradyunsg

Thanks for the reference, @pradyunsg. I will take at it soon!!

damianavila avatar Dec 06 '21 14:12 damianavila

Related (since it involves moving JS from the templates into some other place): https://github.com/pydata/pydata-sphinx-theme/pull/28

damianavila avatar May 02 '22 19:05 damianavila

Isn't it the case ? https://github.com/pydata/pydata-sphinx-theme/blob/adc8b1d7519ed164c5c5fec56dc958ac039de9c9/src/pydata_sphinx_theme/assets/scripts/index.js#L275

12rambau avatar Oct 18 '22 07:10 12rambau

Yes, this is done!

drammock avatar Oct 18 '22 11:10 drammock