pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Think of deprecating usage of toggle buttons and dropdown in favor of native sphinx collapsible admonition.

Open Carreau opened this issue 1 year ago • 2 comments

See https://github.com/sphinx-doc/sphinx/pull/12507, sphinx is implementing "native' collapsible admonition,

I know there are a few issue with accessibility for those dropdown and toggle-buttons.

I think it would be a better use of resources to focus on making acessibilty better with the current upstream PR and work to deprecated the usage of sphinx-design and sphinx-toggle-buttons directives in favor of native ones.

Carreau avatar Jul 18 '24 15:07 Carreau

I would be in favour of using and improving accessibility on the native collapsible components one that is in Sphinx. That would help also reduce maintenance burden on ourend.

Though we'd need to come up with a depreciation strategy to minimise unwanted/negative impact on our users.

trallard avatar Jul 22 '24 11:07 trallard

(9 months later) I'm also in favor of leveraging sphinx's upstream "collapsible" admonition. As of right now it's still not released, presumably it will be in 8.1.4 (or 8.2.0 if they do a minor bump). For right now all we could do is try it out in a test on the CI job that uses sphinx dev, which doesn't seem worth it to me.

drammock avatar Feb 04 '25 17:02 drammock