pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Published 20 hours ago • verified publisher icon pydata

MAINT - Style fixes following design system implementation

Open trallard opened this issue 11 months ago • 6 comments

I am opening this issue as a way to track little nags here and there that were missed through some of the accessibility-related PRs merged recently (i.e., #1174 and #1353)

Note Click on the "Sample images" expandable component to see sample screenshots

If anyone encounters other nags, feel free to add to this issue or conversation 🙌🏽 feedback is always welcome!

Identified nags

  • [ ] Option lists style should align with inline code style

    Sample images

    Inline code styling: Theme_Structure_and_Layout_—_PyData_Theme_documentation

    Option lists styling: Lists_—_PyData_Theme_documentation

  • [ ] Table of Contents: fix the link underline decoration so that it is not applied to the gap between the icon and text

    Sample images

    Table of contents icon + link: Admonitions_—_PyData_Theme_documentation

    An icon + link example in text: Generic_items_—_PyData_Theme_documentation

  • [x] Fix focus visible state of clickable cards - currently, the focus-visible box only appears around the bottom of the card

    Sample images

    Sphinx_Design_Components_—_PyData_Theme_documentation - Clickable card focused through keyboard

  • [ ] Light theme only: Fix colour contrast for links on deprecation admonitions (should be fixed by using the same shade of teal as we do in the inline code links --pst-color-inline-code-links) - also note for @trallard to check: version added and version changed variants

    Sample images

    Colour_Contrast_Analyser__CCA__and_Branding_and_logo_—PyData_Theme_documentation_and_New_Issue·_pydata_pydata-sphinx-theme

trallard avatar Jul 13 '23 10:07 trallard