pandas-datareader icon indicating copy to clipboard operation
pandas-datareader copied to clipboard

Fix `get_data_yahoo()` Bug in windows when start date is earlier than 1970-1-1 8:00

Open ice-tong opened this issue 3 years ago • 1 comments

Fix get_data_yahoo() Bug in windows when satrt date is earlier than 1970-1-1 8:00

Bug reproduce:

from pandas_datareader import data as web
web.get_data_yahoo("IBM", start='1968-02-28', end='2020-02-08', interval="d")

ERROR Overflow error: mktime argument out of range

  • [ ] closes #xxxx
  • [ ] tests added / passed
  • [ ] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ ] passes black --check pandas_datareader
  • [ ] added entry to docs/source/whatsnew/vLATEST.txt

ice-tong avatar Feb 10 '21 13:02 ice-tong

Codecov Report

Merging #846 (d22667c) into master (90f155a) will decrease coverage by 0.56%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   64.36%   63.79%   -0.57%     
==========================================
  Files          62       62              
  Lines        2848     2848              
  Branches      305      305              
==========================================
- Hits         1833     1817      -16     
- Misses        939      957      +18     
+ Partials       76       74       -2     
Impacted Files Coverage Δ
pandas_datareader/tests/test_eurostat.py 61.90% <0.00%> (-21.43%) :arrow_down:
pandas_datareader/io/util.py 66.66% <0.00%> (-11.12%) :arrow_down:
pandas_datareader/compat/__init__.py 78.78% <0.00%> (-3.04%) :arrow_down:
pandas_datareader/io/sdmx.py 88.57% <0.00%> (-2.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90f155a...d22667c. Read the comment docs.

codecov-io avatar Feb 10 '21 13:02 codecov-io