bottleneck
bottleneck copied to clipboard
pydata
Fix segfaulting issue with reduce iterator
Edit is much smaller than diff suggests - mostly just whitespace due to an extra layer of indentation.
The test added generates the segfault described in https://github.com/pydata/bottleneck/issues/381 without the rest of the change, and then the other change fixes this.
This condition only actualyl needs to be that the last non-zero-strided axis is also the smallest non-zero-strided axis, but this was simpler to write.
Hello I rebased this to try to merge it but the test segfaults in the CI...
Removing the change to iterators.h, the tests still cause a segfault - ie current state on master is broken.
The change of reverting the previous release means its quite a lot of effort to work out what the correct fix would now be.
EG you've reverted a load of bugfixes such as https://github.com/pydata/bottleneck/commit/a8dbfdcc82adbb2778dce4f7b7170de3d27ef23f, and removed the tests that got added for them...
Why? Can you readd all of these please?
Hello, the reason is explained here https://github.com/pydata/bottleneck/issues/388#issuecomment-1042726792 . We needed to release some fixes and the state of the main branch was inconsistent.
The previous state is in stored in develop. Feel free to cherry pick the commit you need to fix this.