pydantic-extra-types icon indicating copy to clipboard operation
pydantic-extra-types copied to clipboard

Country specific types

Open hirotasoshu opened this issue 2 years ago • 5 comments

In #30, the ABARouting number was implemented, which is used only in US banks. In this regard, I have a question/suggestion: maybe it is worth putting the types that are specific to some countries/regions in separate modules or even in separate packages? Personally, I prefer the idea of separate packages for different countries, it's easier to maintain. We can create a template that is divided into modules depending on the area of life. @yezz123 what do you think?

hirotasoshu avatar May 05 '23 10:05 hirotasoshu

Hey @hirotasoshu !

I can't mainly understand what you mean by :

it is worth putting the types that are specific to some countries/regions in separate modules or even in different packages?

because right now mostly we can do a country as an entry point and then we can add other countries's banks

yezz123 avatar May 07 '23 22:05 yezz123

@yezz123 That's roughly what I meant, not just for banks, but also for other types, such as postal code, taxpayer identification number, and more

because right now mostly we can do a country as an entry point and then we can add other countries's banks

At this moment, it is possible to divide into entry points in this package, but as the package grows, it will be more difficult to maintain. Therefore, I proposed to separate such types into separate packages that could be maintaned by residents of different countries (for example, types specific to the United States by residents of the United States), and leave only types that are not tied to the specifics of certain countries in this package.

hirotasoshu avatar May 09 '23 09:05 hirotasoshu

metoo, i will clone this repo, and develop based on the repo.

me-v2 avatar Jul 11 '23 08:07 me-v2

@yezz123 passport number based on country.

me-v2 avatar Jul 11 '23 08:07 me-v2

@yezz123 I found a reference to make it clearer what I meant: https://github.com/django/django-localflavor

hirotasoshu avatar Jul 30 '23 11:07 hirotasoshu