pydantic-core icon indicating copy to clipboard operation
pydantic-core copied to clipboard

add flag to allow only finite float values

Open PrettyWood opened this issue 2 years ago • 3 comments

fix #224

PrettyWood avatar Aug 11 '22 20:08 PrettyWood

Codecov Report

Merging #228 (ed56450) into main (fdf42b8) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   98.66%   98.69%   +0.02%     
==========================================
  Files          48       48              
  Lines        5031     5053      +22     
  Branches       35       35              
==========================================
+ Hits         4964     4987      +23     
+ Misses         67       66       -1     
Impacted Files Coverage Δ
src/errors/kinds.rs 99.15% <ø> (ø)
pydantic_core/_types.py 100.00% <100.00%> (ø)
src/input/input_json.rs 97.51% <100.00%> (ø)
src/input/input_python.rs 98.67% <100.00%> (ø)
src/validators/float.rs 98.90% <100.00%> (+0.13%) :arrow_up:
src/validators/typed_dict.rs 98.89% <0.00%> (+<0.01%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdf42b8...ed56450. Read the comment docs.

codecov-commenter avatar Aug 11 '22 20:08 codecov-commenter

@tiangolo are you happy with such a flag?

PrettyWood avatar Aug 11 '22 20:08 PrettyWood

Thanks for the review! Feedback taken

PrettyWood avatar Aug 12 '22 09:08 PrettyWood

this is great, thanks so much.

samuelcolvin avatar Aug 22 '22 15:08 samuelcolvin