pydantic-core icon indicating copy to clipboard operation
pydantic-core copied to clipboard

try pyo3 branch without lazy errors

Open davidhewitt opened this issue 9 months ago • 1 comments

Change Summary

Testing out https://github.com/PyO3/pyo3/pull/4859, I was just curious to see how much this might affect perf...

Related issue number

N/A

Checklist

  • [ ] Unit tests for the changes exist
  • [ ] Documentation reflects the changes where applicable
  • [ ] Pydantic tests pass with this pydantic-core (except for expected changes)
  • [ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

davidhewitt avatar Mar 26 '25 20:03 davidhewitt

CodSpeed Performance Report

Merging #1675 will degrade performances by 11.3%

Comparing dh/try-pyo3-eager-err (0ee4df2) with main (6c936de)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 154 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_raise_error_value_error 36.8 µs 41.5 µs -11.3%
test_json_direct_list_int 147.8 µs 134.1 µs +10.23%
test_ser_list_of_lists 1.4 ms 1.2 ms +11.44%

codspeed-hq[bot] avatar Mar 26 '25 20:03 codspeed-hq[bot]

Will eventually do the work in PyO3, don't need this branch here.

davidhewitt avatar Jul 14 '25 15:07 davidhewitt