FastUI Add rye and ruff, and local dependency for CI and development

I'm going to write tests with playwright, but before doing that, I found repo a bit messy.

~~So I used PDM as it's conventional tool in pydantic team~~ Samuel asked to use rye instead.

I added some # type ignore, because this PR was not meant to fix all types.

~~about Playwright and ui test, since they usually take quite long time to pass, might make more sense to use "pre push hook" instead of pre commit? I find it very annoying to have some browser running on every commit :) (ofc I can ignore it, till last push, but that's also annoying hahaha)~~

From samuel input, which I also very agree with, we don't need to run playwright tests on any git hooks. Only in CI :) and also a way to execute it manually. Will engineer this in next PR

Apr 28 '24 14:04 ManiMozaffar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

Apr 28 '24 15:04 codecov[bot]

@sydney-runkle lmk if you agree with these changes ^ and your ideas about what i just said in my first comment so I can then start working on playwright tests :)

Apr 28 '24 15:04 ManiMozaffar

hi @ManiMozaffar thanks so much for contributing.

I have a few thoughts:

please lets not use PDM, we use it on Pydantic due to the complex set of dependencies but I really don't love it - I'd suggest using rye, or sticking to what we have now
Playwright tests, while useful, can be pretty frustrating - let's keep the number to a minimum
let's run playwright tests on CI, and of course via a make command, no need for anything else

(btw, we don't really have a default packaging choice right now - pydantic uses PDM, pydantic-core uses pure pip, internal stuff uses poetry, things we're about to release use rye)

Apr 28 '24 16:04 samuelcolvin

Let's not switch package manager at the same time as adding playwright tests.

Apr 28 '24 16:04 samuelcolvin

Hey samuel, thanks for quick check.

please lets not use PDM, we use it on Pydantic due to the complex set of dependencies but I really don't love it - I'd suggest using rye, or sticking to what we have now

Agreed. I was wondering why you're not using rye in pydantic. I can rework PR to use rye instead. Makes much more sense. That pip dependency was kinda bad IMO.

Playwright tests, while useful, can be pretty frustrating - let's keep the number to a minimum

I also asked Sydney some days ago, she also agreed to write test. Playwright is much better than selenium and other alternatives as for my experience, being frustrating depends on the what you test, and how much you test. Testing at correct amount with correct approach, wouldn't be frustrating to maintain. frustrating to run? maybe. that's why I was kinda against running it on pre commit hook.

Let's not switch package manager at the same time as adding playwright tests.

That's why I made this PR. To first decide about package manager, then continue with writing test. Sorry for the branch name, should have renamed it.

Apr 28 '24 16:04 ManiMozaffar

@samuelcolvin, did you consider using https://github.com/prefix-dev/pixi?

Apr 29 '24 06:04 Zaubeerer

Hey @ManiMozaffar,

Thanks for your work here! I can review this thoroughly this afternoon - stay tuned!!

Apr 29 '24 13:04 sydney-runkle

@ManiMozaffar,

Ah shoot, sorry, in my queue for first thing tomorrow :).

Apr 30 '24 00:04 sydney-runkle

A bit more research into rye, found this: https://lucumr.pocoo.org/2024/2/15/rye-grows-with-uv/

According to Armin Ronacher, rye and uv eventually converge into one. So the decision to choose rye might have not been the best there. But I think it might make more sense to just keep using rye for now as it's already there, and if in future rye converge into uv, migrate to uv.

Apr 30 '24 10:04 ManiMozaffar

@ManiMozaffar,

Should we use uv instead?

Apr 30 '24 18:04 sydney-runkle

@ManiMozaffar,

I guess we're using a combo in https://github.com/pydantic/logfire, so we could always migrate to uv down the line.

Apr 30 '24 18:04 sydney-runkle

Ah also, looks like there are some changes with the __init__.py file with the components, likely due to my docs additions.

Apr 30 '24 18:04 sydney-runkle

Ok great, I'll rebase the branch tomorrow and do the changes requested @sydney-runkle

Apr 30 '24 19:04 ManiMozaffar

@sydney-runkle build docs fails. I don't have the "PPPR_TOKEN", so I can't test and debug it locally. I'm not even sure why it's failing, it said it requires black to function, so maybe pip install black would solve it? but then why didn't it happen before this PR? i think the diagnostic might be wrong.

May 01 '24 13:05 ManiMozaffar

@sydney-runkle build docs fails. I don't have the "PPPR_TOKEN", so I can't test and debug it locally.

Ah yes, this is a barrier we need to work on. This is bc of the documentation PR that I merged recently. The local failure makes sense, but I'm not sure why it's failing on CI. I'll look into this!