atomai icon indicating copy to clipboard operation
atomai copied to clipboard

3D fcnn

Open tommycwong opened this issue 2 years ago • 3 comments

Updated fcnn blocks with 3D versions. I am wondering if separate 3D versions of fcnns should be created or if existing fcnns should be updated with ndim arg in fcnn.py.

tommycwong avatar Feb 10 '23 22:02 tommycwong

Thank you, Tommy. I think 3D convolutions can be simply used as drop-ins. Can you please write it in a more compact way, without if/else? For example,

def get_conv(dim: int) -> Type[nn.Module]:
    conv_dict = {1: nn.Conv1d, 2: nn.Conv2d, 3: nn.Conv3d}
    return conv_dict[dim]

PS. Not sure whether List is a correct type annotation for **kwargs.

ziatdinovmax avatar Feb 11 '23 03:02 ziatdinovmax

I am not sure what output type I should put for the type annotation.

tommycwong avatar Mar 31 '23 20:03 tommycwong

I am not sure what output type I should put for the type annotation.

nn.Module

ziatdinovmax avatar Mar 31 '23 21:03 ziatdinovmax