pycon.tw icon indicating copy to clipboard operation
pycon.tw copied to clipboard

build(node): upgrade to node v20.11.0 and related dependency

Open rockleona opened this issue 9 months ago β€’ 7 comments

Types of changes

  • [x] Other (please describe)

Description

  • Update Node to v20.11.0 (lts/iron)
  • Update some packages
    • autoprefixer
    • browserify
    • node-sass
    • postcss-cli

Related Issue

Ideal to resolve all Dependabot alerts

rockleona avatar May 06 '24 08:05 rockleona

I was trying to run dev container on Windows WSL2 (Ubuntu 22.04), but will got this error when running docker-compose-dev.yml.

Will try to use Ubuntu tomorrow.

image

rockleona avatar May 06 '24 08:05 rockleona

~~yap I've aware that the script cannot run on Windows...still WIP~~ https://github.com/pycontw/pycon.tw/pull/1192

hmmm it should have worked on WSL. Which docker version do you use now?

mattwang44 avatar May 06 '24 08:05 mattwang44

should also edit the version defined in .github/workflows/ci.yaml for CI

mattwang44 avatar May 06 '24 08:05 mattwang44

hmmm it should have worked on WSL. Which docker version do you use now?

Wondering if this info is helpful or not

image

rockleona avatar May 06 '24 08:05 rockleona

should also edit the version defined in .github/workflows/ci.yaml for CI

Sure, I just notice the ci error too, I think I will wait #1194 merged and edit all node version at once.

rockleona avatar May 06 '24 09:05 rockleona

Hi @mattwang44, things getting weird now..., I checkout master branch to run enter_dev_env.sh on Ubuntu22.04, but still having this error, I'm wondering how should I do in this stage.😒

Error image

Docker Version image

rockleona avatar May 07 '24 02:05 rockleona

QQ

  • Did you try cleanup the existing images & containers?
  • Would you please try to run the script on GitHub Codespace (it was functional a couple of weeks ago)?

I'm afraid that I do not have enough time to cope with this issue until next week.

mattwang44 avatar May 07 '24 07:05 mattwang44

Hi @mattwang44 , I think I'm making the first step done upgrading the node packages, please have a review.

rockleona avatar May 31 '24 10:05 rockleona

QQ

  • Did you try cleanup the existing images & containers?
  • Would you please try to run the script on GitHub Codespace (it was functional a couple of weeks ago)?

I'm afraid that I do not have enough time to cope with this issue until next week.

And yes....., I totally forgot I did not cleanup all images, no wonder it always failed.

rockleona avatar May 31 '24 10:05 rockleona

ζœ‰ conflict θ¨˜εΎ—ε…ˆθ§£ζŽ‰ζ­ο½ž

mattwang44 avatar May 31 '24 14:05 mattwang44

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.99%. Comparing base (0fa2454) to head (adeb5aa). Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files          81       81           
  Lines        3057     3057           
=======================================
  Hits         2262     2262           
  Misses        795      795           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 03:06 codecov[bot]

@SivanYeh please help to merge/deploy this PR whenever you think it's good to go

mattwang44 avatar Jun 11 '24 05:06 mattwang44

@SivanYeh please help to merge/deploy this PR whenever you think it's good to go

There're several collaborations going on the same platforms within two weeks. I may act more conservative atm lol. Let me deploy a test branch "temp_master" these two weeks. If everything goes smooth, I will merge then.

SivanYeh avatar Jun 11 '24 14:06 SivanYeh