pycon.tw icon indicating copy to clipboard operation
pycon.tw copied to clipboard

chore(sponsor): remove sponsor-related deprecated code

Open mattwang44 opened this issue 1 year ago • 9 comments

Types of changes

  • [ ] Bugfix
  • [ ] New feature
  • [x] Refactoring
  • [ ] Breaking change (any change that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Other (please describe)

Description

remove deprecated sponsor-related code

Note that I only modified/deleted those templates and static from 2023 code.

mattwang44 avatar Mar 16 '23 04:03 mattwang44

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.99%. Comparing base (134b60e) to head (0303af9).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           rm-schedule-model-and-views    #1133      +/-   ##
===============================================================
+ Coverage                        73.16%   73.99%   +0.83%     
===============================================================
  Files                               83       81       -2     
  Lines                             3115     3057      -58     
===============================================================
- Hits                              2279     2262      -17     
+ Misses                             836      795      -41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 16 '23 06:03 codecov-commenter

@Ritabear please review the unit tests of sponsor API

mattwang44 avatar Mar 16 '23 06:03 mattwang44

@SivanYeh @erik1110 please join as the reviewer for the unit test part, thanks!

mattwang44 avatar Apr 23 '23 07:04 mattwang44

@erik1110 @SivanYeh any progress here?

mattwang44 avatar Jun 12 '23 05:06 mattwang44

@erik1110 @SivanYeh any progress here? "I have set up the environment and am currently researching how to write test examples. I have left some questions in the discussion thread."

erik1110 avatar Jun 18 '23 02:06 erik1110

@erik1110 @SivanYeh any progress here? @mattwang44 Same as Erik. Yet Josix may assign it to other member because of the approaching due. I would continue reading codes and asking.

SivanYeh avatar Jun 18 '23 02:06 SivanYeh

will rebase again after #1132 is merged

mattwang44 avatar Oct 10 '23 18:10 mattwang44

Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time....

mattwang44 avatar Apr 04 '24 16:04 mattwang44

@mattwang44 LGTM. I will resolve the conflix and create a new PR on src/templates/pycontw-2024 with similar redundancy

SivanYeh avatar Apr 05 '24 15:04 SivanYeh

rebased

mattwang44 avatar Apr 15 '24 09:04 mattwang44