support --no-destroy-on-error for up()

[eighthave]

vagrant up has the option --no-destroy-on-error which is very helpful for debugging. It would be nice if python-vagrant supported it, and it looks simple to add. I would just add destroy_on_error=True as an arg to vagrant.up() then pass the right arg depending on that value, something like:

    if not destroy_on_error:
        destroy_on_error_arg = "--no-destroy-on-error"

Here's a reference:

 ~ $ vagrant up --help
Usage: vagrant up [options] [name|id]

Options:

        --[no-]provision             Enable or disable provisioning
        --provision-with x,y,z       Enable only certain provisioners, by type or by name.
        --[no-]destroy-on-error      Destroy machine if any fatal error happens (default to true)
        --[no-]parallel              Enable or disable parallelism if provider supports it
        --provider PROVIDER          Back the machine with a specific provider
        --[no-]install-provider      If possible, install the provider if it isn't installed
    -h, --help                       Print this help
 ~ $ 

[konstruktoid]

Hi @eighthave, you basically got a PR all done already, want to submit one as well? :)

[eighthave]

sure I can do it, if it is something you'd want to merge

[konstruktoid]

Sure thing, seems like an option that can come in handy.

[eighthave]

https://github.com/pycontribs/python-vagrant/pull/129

[sangdrax8]

I just ran into this today, and it would be really helpful to still have. I was testing Talos with vagrant and using ansible to make API calls to it. When I got to build it in molecule, there is always a failure to log in because it doesn't support ssh. If I could just tell it to ignore the failure everything would work. As it is now (with libvirt) it deletes the VM and I can't get around it.