jira icon indicating copy to clipboard operation
jira copied to clipboard

project roles: make adding groups work

Open valentijnscholten opened this issue 4 years ago • 3 comments

The Role (project role) resource has a method add_user that, according to its documentation and parameters, should be able to add either users or groups to a project role. The adding of groups was not (yet) implemented. This PR implements that.

Please note that JIRA server only supports either adding users XOR groups in a single request. So I have added a quick check to raise a clear error. The error message from JIRA is some vague 400 error about it being unable to parse the json request.

it's not perfect, but at least the method now works according to its docs.

valentijnscholten avatar Dec 12 '19 21:12 valentijnscholten

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 11 '20 21:01 stale[bot]

@valentijnscholten please merge in master, solve conflicts

studioj avatar May 24 '21 14:05 studioj

thx => CI is running, if green it'll get reviewed

codacy is failing atm because of this https://app.codacy.com/gh/pycontribs/jira/pullRequest?prid=7435647 black is failing on resources.py https://github.com/pycontribs/jira/pull/884/checks?check_run_id=2657924451#step:8:47

studioj avatar May 24 '21 16:05 studioj

stale for 4 months => close for now

studioj avatar Jun 02 '23 21:06 studioj