jira icon indicating copy to clipboard operation
jira copied to clipboard

adding warning when requests_futures isnt installed

Open RichieCahill opened this issue 1 year ago • 4 comments

This is a super small pr. I dont think it requires any new tests because of its nature. Please let me know if I did anything wrong.

RichieCahill avatar May 25 '24 18:05 RichieCahill

@adehad / @studioj this one looks good to me as-is, but I wonder if the constructor would be a better place for this warning considering it wouldn't be visible until the code attempts to execute the _fetch_pages method? I think it'd be better if the import, along with the assignment of the async_workers and async_class, happens in the constructor itself, that way you get an instant warning that a requirement is missing.

dimitarOnGithub avatar Jun 26 '24 15:06 dimitarOnGithub

should we insted of warning if async=true and requests_futures isnt installed just raise an exception

RichieCahill avatar Jul 11 '24 04:07 RichieCahill

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

github-actions[bot] avatar Sep 04 '24 11:09 github-actions[bot]

@adehad please take a look at this pr i have updated parts of it

RichieCahill avatar Oct 07 '24 18:10 RichieCahill