enrich icon indicating copy to clipboard operation
enrich copied to clipboard

test_rich_console_ex fails with rich 12.5.1

Open Chedi opened this issue 2 years ago • 3 comments

The following test (test_rich_console_ex) fails with:

  • enrich 1.2.7
  • rich 12.5.1
  • python 3.10

======================================================================== src/enrich/test/test_console.py::test_rich_console_ex

____________________________ test_rich_console_ex _____________________________

def test_rich_console_ex() -> None: """Validate that ConsoleEx can capture output from print() calls.""" console = Console(record=True, redirect=True) console.print("alpha") print("beta") sys.stdout.write("gamma\n") sys.stderr.write("delta\n") # While not supposed to happen we want to be sure that this will not raise # an exception. Some libraries may still sometimes send bytes to the # streams, notable example being click. # sys.stdout.write(b"epsilon\n") # type: ignore text = console.export_text()

   assert text == "alpha\nbeta\ngamma\ndelta\n"

E AssertionError: assert 'alpha\nbeta...elta\ndelta\n' == 'alpha\nbeta\ngamma\ndelta\n' E alpha E beta E + beta E + gamma E gamma E delta E + delta

src/enrich/test/test_console.py:23: AssertionError ----------------------------- Captured stdout call ----------------------------- alpha beta gamma delta

========================================================================

Chedi avatar Sep 16 '22 12:09 Chedi

A PR would have being quite useful here.

ssbarnea avatar Oct 04 '22 10:10 ssbarnea

This is caused by https://github.com/Textualize/rich/issues/2172 and we will need to update the code to address this.

ssbarnea avatar Oct 04 '22 11:10 ssbarnea

This is caused by Textualize/rich#2172 and we will need to update the code to address this.

Just opened an upstream PR, fyi.

tinvaan avatar Jan 10 '23 21:01 tinvaan