ansi2html icon indicating copy to clipboard operation
ansi2html copied to clipboard

❤️‍🩹 Looking for maintainers!

Open ssbarnea opened this issue 4 years ago • 17 comments

This project could really benefit from some love. I am looking for others that are willing to help maintaining it as my time is very limited these days.

Please state your interest here, I am more than happy to add new contributors to the project.

ssbarnea avatar Sep 01 '21 09:09 ssbarnea

@ssbarnea I would be interested in helping out. I have some knowledge of python, as well as some knowledge of bash & CI. Let me know how I can assist!

iofq avatar Oct 04 '21 01:10 iofq

I would make it a single executable file, which can be just copied without installation.

abitrolly avatar Nov 12 '21 20:11 abitrolly

@abitrolly Probably you can look into projects that aim to do this by packaging python, deps into executables but the project itself will still be a python library. I doubt we will ever start publishing binaries for it on each platform, is a "bit" out of scope.

ssbarnea avatar Nov 17 '21 11:11 ssbarnea

The idea is to have a single executable ansi2html.py, not binaries.

abitrolly avatar Nov 17 '21 14:11 abitrolly

The library already has 5 files and combining them together would not make it easier to maintain. If you want to create a single file you can look at various projects that aim to do this. Lucky for us we do not really have external dependencies.

Still, i do not think that the project itself would benefit from that.

ssbarnea avatar Nov 17 '21 14:11 ssbarnea

There are five files.

  • https://github.com/pycontribs/ansi2html/blob/main/ansi2html/init.py - 3 lines, import function and export it, no logic
  • https://github.com/pycontribs/ansi2html/blob/main/ansi2html/main.py - 4 lines, import function to run, no logic
  • https://github.com/pycontribs/ansi2html/blob/main/ansi2html/converter.py - 764 LOC, actual meat
  • https://github.com/pycontribs/ansi2html/blob/main/ansi2html/style.py - 270 lines, 100 of which are color constants
  • https://github.com/pycontribs/ansi2html/blob/main/ansi2html/util.py - 5 lines, a single function that is not used

Keeping styling code separate from parser kind of makes sense, but for me having a single file that I can drag and drop in my project has some utility value as serving a replacement for ansi2html.sh.

abitrolly avatar Nov 18 '21 12:11 abitrolly

You may want to investigate pipx, py2exe or other similar projects that can help you encapsulate python code. Lets avoid polluting this thread with this feature request. You are welcomed to create a feature request for it but I doubt we will do it.

ssbarnea avatar Nov 18 '21 14:11 ssbarnea

Hi @ssbarnea I'm a past contributer and happy to team up on things ansi2html.

hartwork avatar Jan 31 '22 18:01 hartwork

@hartwork If you're a veteran, I'd appreciate your thoughts on #126

echuber2 avatar Jan 31 '22 18:01 echuber2

@hartwork welcome back! Check https://github.com/pycontribs/ansi2html/invitations and that will give you maintain role.

ssbarnea avatar Feb 01 '22 10:02 ssbarnea

@ssbarnea thank you! :pray:

hartwork avatar Feb 01 '22 15:02 hartwork

Hey - are you still looking for some help? I am the author of pytest-tui, and I have started using your library as a way to write the console output from Pytest to HTML. I might be able to contribute.

jeffwright13 avatar Jul 31 '22 03:07 jeffwright13

There are definitely open issues that could use more hands with analysis and fixing.

hartwork avatar Jul 31 '22 13:07 hartwork

I am more than happy to help you takeover maintenance and I will provide help. Main focus is to keep CI/CD (GHA) green, which usually involves some changes from time to time.

Best is to ping me on matrix/irc so we can address things in real time.

ssbarnea avatar Jul 31 '22 15:07 ssbarnea

I feel dumb, but I don't know what matrix is. I do know what irc is but - what channel? Where?

jeffwright13 avatar Jul 31 '22 23:07 jeffwright13

@jeffwright13 Check https://github.com/ssbarnea for links to these channels. In fact even google chat with my email should work but i might little bit longer time for me to reply there.

ssbarnea avatar Aug 01 '22 11:08 ssbarnea

Sorry for the late reply, I was out of town. I will check out the link above and reach out.

jeffwright13 avatar Aug 05 '22 17:08 jeffwright13