python-isal icon indicating copy to clipboard operation
python-isal copied to clipboard

Release 1.8.0

Open rhpvorderman opened this issue 3 months ago • 2 comments

Release checklist

  • [x] Check outstanding issues on JIRA and Github.
  • [x] Check latest documentation looks fine.
  • [x] Create a release branch.
    • [x] Change current development version in CHANGELOG.rst to stable version.
  • [x] Check if the address sanitizer does not find any problems using tox -e asan
  • [x] Merge the release branch into main.
  • [x] Created an annotated tag with the stable version number. Include changes from CHANGELOG.rst.
  • [x] Push tag to remote. This triggers the wheel/sdist build on github CI.
  • [x] merge main branch back into develop.
  • [x] Build the new tag on readthedocs. Only build the last patch version of each minor version. So 1.1.1 and 1.2.0 but not 1.1.0, 1.1.1 and 1.2.0.
  • [x] Create a new release on github.
  • [ ] Update the package on conda-forge.

rhpvorderman avatar Sep 10 '25 06:09 rhpvorderman

For 1.8.0, PyPy wheels are missing on PyPI. They were still provided for 1.7.2.

See also https://github.com/pycompression/xopen/pull/173 .

marcelm avatar Oct 13 '25 09:10 marcelm

Yeah, installing on pypy in CI just fails to build:

      gcc -pthread -DNDEBUG -O2 -fPIC -I/tmp/tmpxvxlt3xa -I/opt/hostedtoolcache/PyPy/3.10.16/x64/include/pypy3.10 -c src/isal/isal_zlibmodule.c -o build/temp.linux-x86_64-pypy310/src/isal/isal_zlibmodule.o
      src/isal/isal_zlibmodule.c:57: warning: "Py_UNREACHABLE" redefined
         57 | #define Py_UNREACHABLE() Py_FatalError("Reached unreachable state")
            |
      In file included from /opt/hostedtoolcache/PyPy/3.10.16/x64/include/pypy3.10/Python.h:42,
                       from src/isal/isal_shared.h:23,
                       from src/isal/isal_zlibmodule.c:26:
      /opt/hostedtoolcache/PyPy/3.10.16/x64/include/pypy3.10/pymacro.h:99: note: this is the location of the previous definition
         99 | #  define Py_UNREACHABLE() __builtin_unreachable()
            |
      gcc -pthread -shared -Wl,-Bsymbolic-functions build/temp.linux-x86_64-pypy310/src/isal/isal_zlibmodule.o /tmp/tmpxvxlt3xa/bin/isa-l.a -o build/lib.linux-x86_64-pypy310/isal/isal_zlib.pypy310-pp73-x86_64-linux-gnu.so
      /usr/bin/ld: cannot find /tmp/tmpxvxlt3xa/bin/isa-l.a: No such file or directory
      collect2: error: ld returned 1 exit status
      error: command '/usr/bin/gcc' failed with exit code 1

Dreamsorcerer avatar Oct 14 '25 23:10 Dreamsorcerer

That is odd, I followed the normal release procedures. Very odd that PyPY wheels aren't build.

Thanks for letting me know. I don't know in what timeframe I can address this as due to a concussion I can only work a limited time on the computer.

rhpvorderman avatar Dec 01 '25 08:12 rhpvorderman

CIBuildwheel did not build the PyPy wheels for some reason? I see it in the build logs. That is really odd.

rhpvorderman avatar Dec 01 '25 08:12 rhpvorderman

Cannot determine the cause of this quickly. Delegating issue to todo list: https://github.com/pycompression/python-isal/issues/245

rhpvorderman avatar Dec 01 '25 08:12 rhpvorderman