psydac icon indicating copy to clipboard operation
psydac copied to clipboard
verified publisher icon pyccel

CI test fixes + PETSc caching

Open kvrigor opened this issue 1 year ago • 1 comments

#408 observed failures on the macOS test, presumably related to the recent changes in the macOS runner. This PR will attempt to replicate this issue and fix it.

kvrigor avatar Jun 12 '24 14:06 kvrigor

Update 19.06

  • [x] Fix to new macOS runner applied to settings.py
  • [x] Implemented PETSc caching in CI. This shaves ~2.5 minutes off the total test time.

Update 24.06

  • [x] igakit numpy 2.0.0. bugfix: https://github.com/dalcinl/igakit/pull/4

kvrigor avatar Jun 19 '24 10:06 kvrigor

@yguclu While we're at speeding the CI workflow, do you think we should enable fail-fast: true here? Perhaps it makes sense to immediately abort all tests as soon as one fails.

https://github.com/pyccel/psydac/blob/fe14755a03cfb066b45f0ea81813d384e0c8a7c7/.github/workflows/continuous-integration.yml#L15-L16

kvrigor avatar Aug 20 '24 07:08 kvrigor

@yguclu While we're at speeding the CI workflow, do you think we should enable fail-fast: true here? Perhaps it makes sense to immediately abort all tests as soon as one fails.

https://github.com/pyccel/psydac/blob/fe14755a03cfb066b45f0ea81813d384e0c8a7c7/.github/workflows/continuous-integration.yml#L15-L16

The fail-fast option applies to the entire job matrix. If it is set to true, GitHub will cancel all in-progress and queued jobs in the matrix as soon as one job fails. For example, in the case that our tests fail on Ubuntu, it will also stop the macOS jobs... This makes it harder to catch a platform-specific problem IMHO.

yguclu avatar Aug 20 '24 08:08 yguclu