pybind11_mkdoc icon indicating copy to clipboard operation
pybind11_mkdoc copied to clipboard

Make generated file use valid C++ identifiers

Open mgeplf opened this issue 1 year ago • 2 comments

  • according to https://en.cppreference.com/w/cpp/language/identifiers
  • identifiers with a double underscore anywhere;
  • identifiers that begin with an underscore followed by an uppercase letter;
  • in the global namespace, identifiers that begin with an underscore.
  • clang w/ -Weverything is including -Wreserved-id-macro, which fails with the current macro naming scheme.

  • cleaned up tests a bit

mgeplf avatar Jun 28 '23 11:06 mgeplf

Test appear to be failing w/ clang>=15.0.7, but work with clang<=14.0.6.

mgeplf avatar Jun 28 '23 12:06 mgeplf

Test appear to be failing w/ clang>=15.0.7, but work with clang<=14.0.6.

I tried locally, and with llvm-16 then the python clang==16.0.1.1works, so to not have to pinclang`, updated library versions would need to be installed.

mgeplf avatar Jun 28 '23 12:06 mgeplf