[BUG]: Coverity issue in dispatcher: Possible dereferencing null pointer self_value_and_holder.type

[oleksandr-pavlyk]

Required prerequisites

• [X] Make sure you've read the documentation. Your issue may be addressed there.
• [X] Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
• [X] Consider asking first in the Gitter chat room or in a Discussion.

What version (or hash if on master) of pybind11 are you using?

2.10.2

Problem description

Coverity scan highlights possible explicit null pointer dereferencing in pybind11 dispatcher function in "pybind11.h".

The tools indicates that self_value_and_holder variable is initialized with default-constructed value_and_holder class which sets type pointer to NULL:

It stays NULL if overloads->is_constructor condition is false.

The type field is dereferenced here:

This maybe a false positive, since func.is_new_style_constructor might imply overloads->is_constructor, `but I could not determine that conclusively, hence this issue.

Reproducible example code

No response

Is this a regression? Put the last known working version here if it is.

Not a regression

[rwgk]

This one I'd also silence via assert() and -UNDEBUG.

assert(self_value_and_holder.type != nullptr);