PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

#5299 add inverse linear kinetics

Open rtimms opened this issue 3 weeks ago • 3 comments

Description

Adds InverseLinearKinetics submodel

Fixes #5299

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

rtimms avatar Dec 02 '25 12:12 rtimms

Codecov Report

:x: Patch coverage is 97.43590% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 98.76%. Comparing base (ed960f2) to head (909fb25). :warning: Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...m/models/full_battery_models/base_battery_model.py 80.00% 1 Missing :warning:
...nterface/kinetics/inverse_kinetics/base_inverse.py 98.24% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5303      +/-   ##
===========================================
- Coverage    98.77%   98.76%   -0.01%     
===========================================
  Files          321      323       +2     
  Lines        27746    27744       -2     
===========================================
- Hits         27406    27402       -4     
- Misses         340      342       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 02 '25 12:12 codecov[bot]

Looks great Rob, thanks a lot for the quick fix! The branch does work as intended. Just a minor comment above.

Daniel-Nicolae23 avatar Dec 02 '25 16:12 Daniel-Nicolae23

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB