PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Add informative error message to simulation

Open pipliggins opened this issue 2 months ago • 2 comments

Adds an error message informing users that lists of input sets cannot be used with experiments.

Fixes #5200

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

pipliggins avatar Oct 13 '25 11:10 pipliggins

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.77%. Comparing base (86fec31) to head (c9b7c67). :warning: Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5226   +/-   ##
========================================
  Coverage    98.77%   98.77%           
========================================
  Files          321      321           
  Lines        27729    27731    +2     
========================================
+ Hits         27389    27391    +2     
  Misses         340      340           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 13 '25 11:10 codecov[bot]

this looks great, does #5191 change this at all?

@martinjrobins No, #5191 doesn't touch any of the experiment/cycle solution code.

pipliggins avatar Nov 21 '25 10:11 pipliggins