PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Volume fractions and porosity that vary in y and z

Open DrSOKane opened this issue 3 months ago • 2 comments

Added support for porosity and active material volume fractions that vary in y and z, not just x. It appears to work for the z coordinate ("dimensionality": 1) but the y coordinate appears to get replaced with the StateVector between experiment steps. I tried changing all instances of y in lithium_ion_parameters.py to y_cc but that didn't change anything.

Added an example graded_pouch.py to show that it works in one dimension.

DrSOKane avatar Sep 24 '25 15:09 DrSOKane

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.69%. Comparing base (6ff7848) to head (4dfc96c). :warning: Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5214   +/-   ##
========================================
  Coverage    98.69%   98.69%           
========================================
  Files          324      324           
  Lines        28010    28016    +6     
========================================
+ Hits         27645    27651    +6     
  Misses         365      365           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 18 '25 11:11 codecov[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB