PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Process Fucntion refactor to Enforce return_jacp_stacked=True

Open RohitP2005 opened this issue 8 months ago • 2 comments

Description

Refactored the process function in base_solver.pyto simplify its logic and improve maintainability.

Fixes #4970

Type of change

Refactor (non-breaking change that improves code structure) to the process function in the base solver to enforce return_jacp_stacked=True .

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

RohitP2005 avatar May 06 '25 16:05 RohitP2005

@martinjrobins I've refactored the process function in base_solver.py to simplify the logic Could you please take a look at the changes? If everything looks good, we can go ahead and check the CI tests.

Thanks!

RohitP2005 avatar May 06 '25 16:05 RohitP2005

Hi @RohitP2005, I think there is much more to do on this (than just removing the arg. Have you run the tests locally?

Yes , I ran the tests locally and there are errors that needs to addressed. we fix those issues and make the requested changes.

RohitP2005 avatar May 07 '25 13:05 RohitP2005