PyBaMM
PyBaMM copied to clipboard
2D FVM
Description
This pull request contains a 2D finite volume spatial method. It will be a WIP for a bit, making a draft for sharing purposes.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
- No style issues:
nox -s pre-commit - All tests pass:
nox -s tests - The documentation builds:
nox -s doctests - Code is commented for hard-to-understand areas
- Tests added that prove fix is effective or that feature works
Codecov Report
:x: Patch coverage is 95.92593% with 11 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 98.23%. Comparing base (f04a1f8) to head (9d0a2c3).
:warning: Report is 177 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #5002 +/- ##
===========================================
- Coverage 99.09% 98.23% -0.87%
===========================================
Files 306 309 +3
Lines 23659 24972 +1313
===========================================
+ Hits 23446 24531 +1085
- Misses 213 441 +228
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.