PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Adds `max_step` param to `base_solver`

Open medha-14 opened this issue 1 year ago • 3 comments

Description

Fixes #2253

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (back-end change that speeds up the code)
  • [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [ ] All tests pass: $ python -m pytest (or $ nox -s tests)
  • [ ] The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • [ ] Code is commented, particularly in hard-to-understand areas
  • [ ] Tests added that prove fix is effective or that feature works

medha-14 avatar Dec 13 '24 12:12 medha-14

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Marking as a draft for now, thanks for your effort so far!

agriyakhetarpal avatar Jan 08 '25 19:01 agriyakhetarpal

Marking as a draft for now, thanks for your effort so far!

Hello, sorry for inactivity on this, I will work on this and get this done as soon as possible!

medha-14 avatar Jan 22 '25 13:01 medha-14