Use `numpy.typing.NDArray` instead of `np.ndarray`

Open Saransh-cpp opened this issue 1 year ago • 2 comments

I noticed that pybamm uses np.ndarray everywhere, but we should use numpy.typing.NDArray wherever possible (everywhere). Ideally they should be swappable without any errors. Feel free to close this issue if there was a reason to specifically use np.ndarray.

Oct 14 '24 16:10 Saransh-cpp

I would like to work on this issue. Can i pick on this?

Oct 14 '24 18:10 sanjayh-2022

Hi @sanjayh-2022, sure! Please let us know if you need any help with this.

Oct 14 '24 18:10 agriyakhetarpal

i have made the changes accordingly please review it .

Oct 28 '24 05:10 sanjayh-2022