PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

[WIP] Download IDAKLU from pybammsolvers

Open kratman opened this issue 4 months ago • 7 comments

Description

This will separate the IDAKLU C++ code from pybamm.

Type of change

This should speed up CI by skipping the build of the C++ code.

  • [x] Optimization (back-end change that speeds up the code)

Key checklist:

  • [x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • [x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [x] Code is commented, particularly in hard-to-understand areas
  • [x] Tests added that prove fix is effective or that feature works

kratman avatar Oct 03 '24 16:10 kratman