PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Trying to remove shared.py

Open prady0t opened this issue 1 year ago • 3 comments

Description

Trying to remove contents of shared.py using pytest fixtures.

prady0t avatar Sep 01 '24 13:09 prady0t

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 99.46%. Comparing base (08e5cf2) to head (cc61533). :warning: Report is 454 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4401   +/-   ##
========================================
  Coverage    99.46%   99.46%           
========================================
  Files          293      293           
  Lines        22332    22332           
========================================
  Hits         22212    22212           
  Misses         120      120           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 02 '24 13:09 codecov[bot]

@prady0t What is the status of this one?

kratman avatar Oct 01 '24 17:10 kratman

Still working. Will try to push some commits by the end of this week.

prady0t avatar Oct 02 '24 15:10 prady0t

Gentle ping, @prady0t! I feel this can be revisited now?

agriyakhetarpal avatar Nov 13 '24 17:11 agriyakhetarpal

Almost forgot. Let me get back to this.

prady0t avatar Nov 15 '24 14:11 prady0t

@prady0t Is this still relevant?

kratman avatar Jan 07 '25 20:01 kratman

@prady0t Are you still working on this?

kratman avatar May 12 '25 21:05 kratman

Let's close this for now. I don't think it's much useful to remove the shared.py file given its structure.

prady0t avatar May 12 '25 21:05 prady0t

Ok

kratman avatar May 12 '25 21:05 kratman