PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

[Bug]: Half cell negative reaction heating set to 0

Open aabills opened this issue 1 year ago • 0 comments

PyBaMM Version

24.5

Python Version

3.12

Describe the bug

For some reason reaction heating for the half-cell models is set to 0. As a result, the half-cell models are under calculating heat source (which is important for thermal modeling).

Steps to Reproduce

Just look at the code: https://github.com/pybamm-team/PyBaMM/blob/fa68ddc0496853b2abf8ef4ef3cdbca88615befc/pybamm/models/submodels/thermal/base_thermal.py#L148

Relevant log output

No response

aabills avatar Aug 07 '24 21:08 aabills