PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Moving from flat layout to src layout.

Open prady0t opened this issue 1 year ago • 3 comments

Description

Moving to a src layout is a better option overall. You can read more about it here: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/#:~:text=Auto%20color%20theme-,src%20layout%20vs%20flat%20layout,-%23

It was decided internally to move to a src layout.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (back-end change that speeds up the code)
  • [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • [ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [ ] Code is commented, particularly in hard-to-understand areas
  • [ ] Tests added that prove fix is effective or that feature works

prady0t avatar Jun 23 '24 15:06 prady0t

@agriyakhetarpal I think I've added everything, please let me know if I have to add anything else here once the tests are completed.

prady0t avatar Jun 23 '24 15:06 prady0t

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.55%. Comparing base (205ca81) to head (666c626). Report is 262 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4205   +/-   ##
========================================
  Coverage    99.55%   99.55%           
========================================
  Files          288      288           
  Lines        21857    21857           
========================================
  Hits         21760    21760           
  Misses          97       97           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 23 '24 16:06 codecov[bot]

Just noticed, we'll have to fix the doctests and the example notebooks

agriyakhetarpal avatar Jun 23 '24 16:06 agriyakhetarpal

Let's rebase this now, @prady0t

agriyakhetarpal avatar Jul 27 '24 14:07 agriyakhetarpal

@agriyakhetarpal Opened a new PR, I wasn't able to fix the conflicts locally.

prady0t avatar Aug 02 '24 07:08 prady0t

Superseded by #4311

agriyakhetarpal avatar Aug 02 '24 07:08 agriyakhetarpal