PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

fix degradation options when one of the phases has no degradation

Open valentinsulzer opened this issue 1 year ago • 2 comments

Description

Fixes #4164

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (back-end change that speeds up the code)
  • [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • [ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [ ] Code is commented, particularly in hard-to-understand areas
  • [ ] Tests added that prove fix is effective or that feature works

valentinsulzer avatar Jun 10 '24 21:06 valentinsulzer

@valentinsulzer I tagged the new ticket which I made basically simultaneously with this PR

kratman avatar Jun 10 '24 21:06 kratman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (fe39f99) to head (0be7064). Report is 212 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4163   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22086    22086           
========================================
  Hits         21966    21966           
  Misses         120      120           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 15:06 codecov[bot]