PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Pass solver or tol to all eSOH classes/methods

Open rtimms opened this issue 1 year ago • 1 comments

Sometimes the eSOH models/methods fail to converge within the default tolerance (1e-6). It would be good to be able to pass a solver object to the classes/methods to give the user more control. Currently, you can only pass a tolerance to get_initial_stoichiometries. It would be good to make the API uniform across all methods and probably try to clean the code up a bit at the same time - it's extremely convoluted.

rtimms avatar Mar 26 '24 09:03 rtimms

Yeah I just wanted the ticket as more of a reminder to myself to go back and check for them

from @kratman reminder to check for if known_value == with no else (see #3921)

aabills avatar Mar 27 '24 16:03 aabills