PyBaMM
PyBaMM copied to clipboard
Fixes #3441 call processed variables with custom spatial coordinates
Description
Modified the call method to accept **kwargs as a parameter. This will allow any additional keyword arguments to be passed to the method. You can then include these extra arguments when calling the interp method of the _xr_data_array object.
Fixes #3441
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
- [x] New feature (non-breaking change which adds functionality)
- [ ] Optimization (back-end change that speeds up the code)
- [ ] Bug fix (non-breaking change which fixes an issue)
Key checklist:
- [x] No style issues:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code) - [x] All tests pass:
$ python run-tests.py --all
(or$ nox -s tests
) - [x] The documentation builds:
$ python run-tests.py --doctest
(or$ nox -s doctests
)
You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick
(or $ nox -s quick
).
Further checks:
- [ ] Code is commented, particularly in hard-to-understand areas
- [ ] Tests added that prove fix is effective or that feature works
Can you add some tests for this?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
84bfd61
) 99.59% compared to head (bbc63df
) 99.59%.
:exclamation: Current head bbc63df differs from pull request most recent head 22caa58. Consider uploading reports for the commit 22caa58 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #3472 +/- ##
===========================================
- Coverage 99.59% 99.59% -0.01%
===========================================
Files 257 257
Lines 20806 20804 -2
===========================================
- Hits 20722 20720 -2
Misses 84 84
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rtimms I have tried solving the issue, can you please review the same
@Saswatsusmoy Are you still working on this?
@Saswatsusmoy Are you still working on this?
Yeah, I'll be resuming working on this soon
@Saswatsusmoy Feel free to let us know in case you feel stuck with something, Maybe we'd be able to help you out.
We have not had a response from the contributor in four months by now. I think we should be fine with closing the PR, we can reopen whenever – especially because the linked issue is labelled as "low priority" at the moment