PyBaMM
PyBaMM copied to clipboard
Better option checking
The options checking doesn't always work as expected when options are tuples. For example, the following code performs checks if the option "particle size" is "distribution", but "particle size" can be a tuple, in which case the test doesn't run
if options["particle size"] == "distribution":
if options["lithium plating"] != "none":
raise NotImplementedError(
"Lithium plating submodels do not yet support particle-size "
"distributions."
)
The options should be converted to tuples first (where appropriate) and then checks performed on each index.
Can i get the path for the same code?
@rtimms Can you please review this and let me know if any more changes are required in the code.