Refactor of PyBaMM.jl Julia Generation Code
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
- [x] New feature (non-breaking change which adds functionality)
- [ ] Optimization (back-end change that speeds up the code)
- [ ] Bug fix (non-breaking change which fixes an issue)
Key checklist:
- [ ] No style issues:
$ flake8 - [ ] All tests pass:
$ python run-tests.py --unit - [ ] The documentation builds:
$ cd docsand then$ make clean; make html
You can run all three at once, using $ python run-tests.py --quick.
Further checks:
- [ ] Code is commented, particularly in hard-to-understand areas
- [ ] Tests added that prove fix is effective or that feature works
Codecov Report
Base: 99.66% // Head: 99.43% // Decreases project coverage by -0.23% :warning:
Coverage data is based on head (
1cfa50b) compared to base (c89445e). Patch coverage: 93.56% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2363 +/- ##
===========================================
- Coverage 99.66% 99.43% -0.24%
===========================================
Files 269 269
Lines 20206 20415 +209
===========================================
+ Hits 20139 20300 +161
- Misses 67 115 +48
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ybamm/expression_tree/operations/evaluate_julia.py | 93.46% <93.43%> (-6.54%) |
:arrow_down: |
| pybamm/models/base_model.py | 98.56% <100.00%> (+<0.01%) |
:arrow_up: |
| pybamm/simulation.py | 99.77% <0.00%> (-0.23%) |
:arrow_down: |
| pybamm/discretisations/discretisation.py | 99.79% <0.00%> (-0.02%) |
:arrow_down: |
| pybamm/util.py | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
why closed?
making changes, didn't want to keep testing while I do it. Will reopen at some point