superqt icon indicating copy to clipboard operation
superqt copied to clipboard

Why there is PyQt6 upper bound in pyproject toml

Open Czaki opened this issue 9 months ago • 3 comments

In napari constraints, we already pin PyQt6 to 6.8.1

https://github.com/napari/napari/blob/876965fa0598551b745d4181764463398b8c564a/resources/constraints/constraints_py3.12.txt#L410

But here PyQt6 is pinned below 6.7

https://github.com/pyapp-kit/superqt/blob/f9bc33422848a9552b5df0cce697112dcee78177/pyproject.toml#L86

Is there still a reason to keep this pin?

Czaki avatar Mar 17 '25 15:03 Czaki

I can’t remember, but I think there was a known incompatibility… I’d have to go back to the commit that added the pin to remember why. I think it’s mostly fine with newer pyqt6 (I use it all the time), but there might be an edge case

tlambert03 avatar Mar 17 '25 15:03 tlambert03

Due to this: https://github.com/pyapp-kit/superqt/issues/239

cbouss avatar Apr 03 '25 19:04 cbouss

Hm. Comments in PR that closes it suggest that maybe these change could be reverted.

Czaki avatar Apr 03 '25 19:04 Czaki