app-model icon indicating copy to clipboard operation
app-model copied to clipboard

tracking ability to drop pydantic<2

Open tlambert03 opened this issue 1 year ago • 4 comments

Hey @jni, @DragaDoncila, @lucyleeow, @Czaki

No hurry on this, but just wanted to open an issue to track our ability to drop support for pydantic<2. Is this something you guys discuss?

tlambert03 avatar Jan 31 '25 00:01 tlambert03

We have planned to drop pydantic 1.x in 0.6.0 (next release). It wil lbe nice if @jni confirm. As I understnad it will bump app-model version to 0.5.0?

Czaki avatar Jan 31 '25 00:01 Czaki

oh fun! ok great. sure, we can bump app-model to whatever version you like

tlambert03 avatar Jan 31 '25 00:01 tlambert03

I need to check upper bound i napari 0.5.6.

Czaki avatar Jan 31 '25 01:01 Czaki

The napari PR https://github.com/napari/napari/pull/7589

Czaki avatar Feb 09 '25 11:02 Czaki

I see that the napari PR has been merged. Would now be a good time to drop v1 support? I'm trying to update the pydantic version in Debian testing, and one of the obstacles is pydantic-compat, where I ran into the complications shown in https://github.com/pyapp-kit/pydantic-compat/pull/29. I'm wondering if it would be easier to just drop it instead.

I could come up with a PR if that would be something you'd welcome (it looks like enough work that it seems worth checking in advance).

cjwatson avatar Sep 02 '25 11:09 cjwatson

From napari's perspective we no longer need pydantic v1.x compatibility.

jni avatar Sep 02 '25 12:09 jni