app-model icon indicating copy to clipboard operation
app-model copied to clipboard
verified publisher icon pyapp-kit

Tests failing in CI

Open github-actions[bot] opened this issue 1 year ago • 4 comments

A test failed. Please review the workflow logs for details.

github-actions[bot] avatar Jan 31 '25 00:01 github-actions[bot]

I expect pydantic==2.11.0a1 to be a source of problem. Same like in https://github.com/napari/napari/issues/7570

Czaki avatar Jan 31 '25 00:01 Czaki

yeah, must be... looks like you have a slightly different error though. I was actually just opening an issue to discuss the possible timeline for dropping v1 (don't fear 😂 ... just curious)

tlambert03 avatar Jan 31 '25 00:01 tlambert03

Hm. I have executed test locally.

in pydantic==2.10.6 MenuItemBase._validator gets MenuItem class and MenuItem object

in pydantic==2.11.0a2 MenuItemBase._validator gets MenuItem class and dict object with keys command and when plus ValidationInfo object. Such version fails with recursion error.

Stop using pydantic_compat and importing BaseModel directly from pydantic does not solve the problem.

Czaki avatar Feb 14 '25 18:02 Czaki

opened https://github.com/pydantic/pydantic/issues/11443

Czaki avatar Feb 14 '25 18:02 Czaki