Test ODIM HDF5 importer for DPC files

[dnerini]

Raised in #441

As stated here, the ODIM HDF5 importer should be able to read HDF5 files from DPC. Could someone add tests for those?

@chiara-arpae would you be able to have a look into this? see also discussion in #172

[chiara-arpae]

Hi, sorry for responding so late: I have worked abroad for the last 7 months and I have not looked at many emails and notifications linked to this account during this period. Have you already implemented this test code? If it is not the case, should the test code be implemented in pytest ( https://pysteps.readthedocs.io/en/stable/developer_guide/test_pysteps.html)? Unfortunately I am pretty busy at the moment, but if it is still needed I can try to provide some test code for the ODIM HDF5 reading of DPC files in the future.

Il giorno mer 4 dic 2024 alle ore 20:42 Daniele Nerini < @.***> ha scritto:

Raised in #441 https://github.com/pySTEPS/pysteps/pull/441

As stated here https://github.com/pySTEPS/pysteps/blob/11c04fe615620eccecdfbd705884f9809dbb632b/pysteps/io/importers.py#L1256, the ODIM HDF5 importer should be able to read HDF5 files from DPC. Could someone add tests for those?

@chiara-arpae https://github.com/chiara-arpae would you be able to have a look into this? see also discussion in #172 https://github.com/pySTEPS/pysteps/pull/172

— Reply to this email directly, view it on GitHub https://github.com/pySTEPS/pysteps/issues/442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2PKGUJUXW4OFK7ET3SIN32D5LLTAVCNFSM6AAAAABTA5FF3GVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YTQNRUGM3TQMI . You are receiving this because you were mentioned.Message ID: @.***>

[dnerini]

Hello @chiara-arpae, apologies, I wrote you an answer a couple of days ago, but somehow I forgot to post it... anyway, I wanted to mention that this issue has no urgency, but it would be a nice addition, since it would ensure that the new OPERA reader can still support DPC files as stated in the docstrings.

In essence, this would boil down to add a corresponding test in https://github.com/pySTEPS/pysteps/blob/master/pysteps/tests/test_io_opera_hdf5.py. For this, we would first need to add some test data in the pysteps-data repo, as done for NIMBUS and CIRRUS data, see here https://github.com/pySTEPS/pysteps-data/tree/master/radar/OPERA/20241126.

I assigned you this issue a couple of days ago (when I thought I also posted my answer...), but feel free to change that if you already know that you won't be able to work on this in the foreseable future.