pysteps
pysteps copied to clipboard
Example notebook for optimizing number of frames as described in issue #376
This is a notebook optimizing the number of frames for different lead-times for the Optical Flow (Lucas-Kanade) motion vector computation. The exampls is related to issue #376 but I think the second example commented in that issue should be also added.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.74%. Comparing base (
fc446bc) to head (3f0c4ed). Report is 10 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 83.47% 83.74% +0.27%
==========================================
Files 161 159 -2
Lines 12536 12724 +188
==========================================
+ Hits 10464 10656 +192
+ Misses 2072 2068 -4
| Flag | Coverage Δ | |
|---|---|---|
| unit_tests | 83.74% <ø> (+0.27%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @aitaten , this is looking very good! I will have a closer look, but I was wondering if it wouldn't be better to split this PR into two? Here I would rather keep the tuning tutorial, while the second should be about the INCA motion field -- by the way, I'm not sure why this is implemented in the example only, shouldn't we have it as an additional method in the motion module?
Thanks @dnerini for the review. Including the other example was a mistake so I have removed the unwanted file from the PR (addressed in commit 3f0c4ed). Sorry about that.
I will do, as we talk, a separated PR and branch about the INCA motion field/TREC-like.
(I'm working on this, sorry, just going very slow...)