pywhy-graphs icon indicating copy to clipboard operation
pywhy-graphs copied to clipboard

Check edge types allowed given a `graph_type` passed in export functions

Open adam2392 opened this issue 1 year ago • 1 comments

          What happens if a user has `graph_type="dag"` instead here? Will this function detect that there are `o->` edges and prevent that? Clearly the imported file does not represent a DAG so we shouldn't let the user make this mistake. Or we should have clear tests to show what happens when you import a graph under a different graph assumption than the one it was created with

Originally posted by @jaron-lee in https://github.com/py-why/pywhy-graphs/pull/60#discussion_r1127972816

adam2392 avatar Mar 07 '23 15:03 adam2392

This is mainly for robustness and error-checking within the export submodule

adam2392 avatar Mar 08 '23 16:03 adam2392