Eli a look at synthetic data generation - linear_dataset

[elikling]

Signed-off-by: Eli Kling [email protected]

started an example notebook showcasing the functions for generating synthetic data.

for now just did linear_dataset. This is a good time to get feedback before moving on to the next functions.

I did run into some issues. For one of them I opend an Issue #664. The others could be due to some problem my side (not all function parms recognised)

I realise there is a question of whether this should be part of the documentation. My view is that there is too much code for it to be in the documentations and this is a good way to allow playing with the function and undersdanding it.

[elikling]

How come this did not pass the DCO check? I ensured the commit had the required text!

[elikling]

The issues I mentioned in the notes were resolved when I refreshed doWhy :-) - pull request is relvant - I will correct my notes in the next round.

[amit-sharma]

thanks @elikling for adding this. Based on our discussion in the last meeting, do you think this information will be better as a docstring for the linear_dataset function? I'd encourage you to add the parameter description and the code example as a docstring to the function here, so that users can find this information easily.

[elikling]

Yep - it makes sense to update to Docstrings,

I read up alittle on Docstrings and did my best - see updated datasets.py

Eli

[elikling]

I am closing this pull request as it is now messy - will follow advice and create a fresh branch and a new pull request :-)