dowhy
dowhy copied to clipboard
fixed warnings and progrss bar improvements
Fixed the warnings arising in propensity score estimators and added optional progress bars for refuters
Signed-off-by: Amey Varhade [email protected]
The progress bars have been added; the default is set to False, and the verbose mode from joblib provides updates, but alternatively, this can be used. The warning arising in propensity score estimators, as seen here, is fixed.
The changes are in the commit. I also noticed in the build logs that it failed in the dowhy_demo_dummy_outcome_refuter notebook however, I have not made any modifications to the dummy outcome refuter and in the latest release version it works perfectly fine.
That's okay. Can you push the commit to this branch yemaedahrav:amey/progress-warnings
so it becomes a part of the PR?
Now, this PR has all the relevant commits
@yemaedahrav there is a bug in this PR. Can you check? File ~/work/dowhy/dowhy/dowhy/causal_model.py:422, in CausalModel.refute_estimate(self, estimand, estimate, method_name, show_progress_bar, **kwargs) 414 refuter_class = causal_refuters.get_class_object(method_name) 416 refuter = refuter_class( 417 self._data, 418 identified_estimand=estimand, 419 estimate=estimate, 420 **kwargs 421 ) --> 422 res = refuter.refute_estimate(show_progress_bar) 423 return res
TypeError: refute_estimate() takes 1 positional argument but 2 were given TypeError: refute_estimate() takes 1 positional argument but 2 were given
@all-contributors please add @yemaedahrav for code.